Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default language for content if not set #6369

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: default language for content if not set #6369

wants to merge 3 commits into from

Conversation

giuliaghisini
Copy link
Contributor

if language from retrived content is not set for some reasons, set default language from settings

@netlify Netlify
Copy link

netlify bot commented Oct 3, 2024 •
edited
Loading

✅ Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 709acf3
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66fe727348ddc40008517f4d

davisagli
davisagli requested changes Oct 3, 2024
View reviewed changes
Copy link
Sponsor Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a multilingual site, the default language should be inherited from the container, not from the site default language.

In my opinion this should be handled in the REST API, not here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giuliaghisini @davisagli