Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 22 as LTS, main and recommended Volto version #6371

Merged
merged 15 commits into from
Oct 20, 2024
Merged

Conversation

sneridagh
Copy link
Member

@sneridagh sneridagh commented Oct 3, 2024

https://github.com/nodejs/release#release-schedule

In preparation for Node.js 22 being promoted to LTS in 2024-10-29.

I'd suggest we sync the release of Volto 18 with that.


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #


📚 Documentation preview 📚: https://volto--6371.org.readthedocs.build/

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 163f5a1
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6712de681a08b6000830fccc

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about testing versions, and minor grammar in the news items.

.github/workflows/unit.yml Show resolved Hide resolved
packages/volto/news/6371.breaking Outdated Show resolved Hide resolved
packages/volto/news/6371.internal Outdated Show resolved Hide resolved
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't take a close look at this yet since the builds aren't passing. Let me know when it's ready, or if you need help.

docs/source/contributing/version-policy.md Show resolved Hide resolved
@sneridagh
Copy link
Member Author

sneridagh commented Oct 4, 2024

@davisagli it seems that they deprecated some libraries that are not in core anymore, so some libraries have to stop using them, so we have to update them, or they have to update their deps. I will continue investigating.

parcel-bundler/parcel#9926

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor revision to ensure we have documented "latest two LTS Node.js" as policy.

docs/source/contributing/version-policy.md Outdated Show resolved Hide resolved
docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved
@sneridagh
Copy link
Member Author

It seems that the parcel error will be gone with: nodejs/node#54573 (comment)

@davisagli
Copy link
Member

@sneridagh So we are waiting for a new Node release?

* main: (37 commits)
  Release generate-volto 9.0.0-alpha.19
  Release @plone/providers 1.0.0-alpha.3
  Release @plone/components 2.0.0-alpha.16
  Release @plone/client 1.0.0-alpha.19
  Release @plone/types 1.0.0-alpha.21
  Some types improvements/fixes (#6412)
  [providers] Improve and group providers (#6069)
  Adjust the path to perform a proper `git diff` between the cached and… (#6410)
  Test whether commenting out the `ignore` command has any affect on the Netlify build.
  support depth in getNavigationQuery (#6400)
  Update caniuse Oct24 (#6408)
  Upgraded nextjs deps and configuration (#6388)
  Update `typescript` and `vitest` everywhere (#6407)
  Remove all traces of Jest 24 in core (#6406)
  Release @plone/components 2.0.0-alpha.15
  [components] Fix Select component logic to support `items` use case (#6405)
  Fix clean make command (#6403)
  Release 18.0.0-alpha.46
  Release @plone/components 2.0.0-alpha.14
  Add missing export for new components (#6391)
  ...
@sneridagh
Copy link
Member Author

Node 22.10.0 has been released, and now it seems it works well.

@sneridagh
Copy link
Member Author

We are 🟢 now!
@davisagli Would you wait until 2024-10-29, when 22 is officially LTS?

* main:
  Remove the Plone app from apps folder (#6415)
docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved
docs/source/upgrade-guide/index.md Outdated Show resolved Hide resolved
@davisagli
Copy link
Member

Would you wait until 2024-10-29, when 22 is officially LTS?
@sneridagh I don't see any important reason to wait.

@stevepiercy stevepiercy requested a review from davisagli October 18, 2024 20:56
@sneridagh
Copy link
Member Author

@davisagli yeah, me neither. Let's do it!

@sneridagh sneridagh merged commit e60fe1e into main Oct 20, 2024
69 checks passed
@sneridagh sneridagh deleted the Node22asLTS branch October 20, 2024 07:18
sneridagh added a commit that referenced this pull request Oct 20, 2024
* main:
  Remove last CI tests still in 18 (#6418)
  Node 22 as LTS, main and recommended Volto version (#6371)
  Refactor Aliases control panel and support new filters (#6414)
  Remove the Plone app from apps folder (#6415)
sneridagh added a commit that referenced this pull request Oct 22, 2024
* main: (23 commits)
  Aliases control panel: Improve layout and add CSV upload (#6421)
  Fix site setup access at toolbar by using @actions endpoint. (#6413)
  Remove last CI tests still in 18 (#6418)
  Node 22 as LTS, main and recommended Volto version (#6371)
  Refactor Aliases control panel and support new filters (#6414)
  Remove the Plone app from apps folder (#6415)
  Release generate-volto 9.0.0-alpha.19
  Release @plone/providers 1.0.0-alpha.3
  Release @plone/components 2.0.0-alpha.16
  Release @plone/client 1.0.0-alpha.19
  Release @plone/types 1.0.0-alpha.21
  Some types improvements/fixes (#6412)
  [providers] Improve and group providers (#6069)
  Adjust the path to perform a proper `git diff` between the cached and… (#6410)
  Test whether commenting out the `ignore` command has any affect on the Netlify build.
  support depth in getNavigationQuery (#6400)
  Update caniuse Oct24 (#6408)
  Upgraded nextjs deps and configuration (#6388)
  Update `typescript` and `vitest` everywhere (#6407)
  Remove all traces of Jest 24 in core (#6406)
  ...
sneridagh added a commit that referenced this pull request Oct 25, 2024
* main:
  Client transforms for reducer data (#6422)
  (fix): Enable Volto Login to Redirect Back to Original Route After Authentication  (#6419)
  Test with plone.restapi 9.8.0 (#6430)
  Add German translations for URL management control panel (#6429)
  URL Management control panel: add Edit feature (#6425)
  Remove SEAMLESS mention in bootstrap (#6424)
  Aliases control panel: Improve layout and add CSV upload (#6421)
  Fix site setup access at toolbar by using @actions endpoint. (#6413)
  Remove last CI tests still in 18 (#6418)
  Node 22 as LTS, main and recommended Volto version (#6371)
  Refactor Aliases control panel and support new filters (#6414)
  Remove the Plone app from apps folder (#6415)
  Release generate-volto 9.0.0-alpha.19
  Release @plone/providers 1.0.0-alpha.3
  Release @plone/components 2.0.0-alpha.16
  Release @plone/client 1.0.0-alpha.19
  Release @plone/types 1.0.0-alpha.21
  Some types improvements/fixes (#6412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants