Backport #6309 to Volto 17 #6384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sneridagh
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
@dobri1408 Thanks for pointing this. It is in fact, not a breaking change, as documented in the Release Management Notes:
Let's go for it then!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport PR for PR #6309.
Why I believe this is not a breaking change:
This can be viewed as a bug fix, as the History page appears broken when used on a complex page. This PR aims to resolve that issue.
Although the snapshot changes, it doesn't introduce a breaking change since there is no visual impact. The removal of the span occurs because this fix ensures that RenderBlocks, rather than DefaultView, is used to render the block changes, as it should be.