Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Block Restrictions Across All Nesting Levels #6575

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

TechSubham
Copy link
Member

@TechSubham TechSubham commented Jan 9, 2025

  • [✅] I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • [ ✅] I verified there aren't other open pull requests for the same change.
  • [ ✅] I followed the guidelines in Contributing to Volto.
  • [ ✅] I succesfully ran code linting checks on my changes locally.
  • [ ✅] I succesfully ran unit tests on my changes locally.
  • [ ✅] I succesfully ran acceptance tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes, either in the Storybook or narrative documentation.
  • ✅[ ] I included a change log entry in my commits

Resolved an issue where block restrictions were only applied to top-level blocks, ensuring proper enforcement across all nested levels to prevent duplicates.

Closes #2837

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 88aee4c
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6780416d3a11b0000821c0fb

@stevepiercy
Copy link
Collaborator

@TechSubham please update this PR title ("issue fixed" is not good) and provide a sufficient description so someone can see at a glance what this PR is for. Thank you!

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires a technical review from @plone/volto-team.

packages/volto/news/2837.bugfix Outdated Show resolved Hide resolved
@TechSubham TechSubham changed the title issue fixed Enforce Block Restrictions Across All Nesting Levels Jan 9, 2025
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

News LGTM. Thanks for renaming the PR. We await a tech review. Thank you for your work and patience!

@TechSubham
Copy link
Member Author

@stevepiercy Thanks

@stevepiercy
Copy link
Collaborator

@TechSubham also can you update your branch against main and push? Do you see the Update branch button, and can you click it?

Screenshot 2025-01-09 at 1 26 43 PM

Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TechSubham I think that #2837 issue was not about this... Also it is highly unlikely that the title block appear in a nested context.

Also, that logic applies only to the title block, eg. when there is a title block already in the page, do not allow add another one. So, as you can see the scenario is quite limited.

#2837 wanted to convey another idea/deficiency, not about the specific use case about the title.

@tiberiuichim any feedback about the original issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "block in block" scenarios in Volto
3 participants