-
-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce Block Restrictions Across All Nesting Levels #6575
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for plone-components canceled.
|
@TechSubham please update this PR title ("issue fixed" is not good) and provide a sufficient description so someone can see at a glance what this PR is for. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires a technical review from @plone/volto-team.
Co-authored-by: Steve Piercy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
News LGTM. Thanks for renaming the PR. We await a tech review. Thank you for your work and patience!
@stevepiercy Thanks |
@TechSubham also can you update your branch against |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TechSubham I think that #2837 issue was not about this... Also it is highly unlikely that the title block appear in a nested context.
Also, that logic applies only to the title block, eg. when there is a title block already in the page, do not allow add another one. So, as you can see the scenario is quite limited.
#2837 wanted to convey another idea/deficiency, not about the specific use case about the title.
@tiberiuichim any feedback about the original issue?
Resolved an issue where block restrictions were only applied to top-level blocks, ensuring proper enforcement across all nested levels to prevent duplicates.
Closes #2837