Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect copied state useClipboard #6585

Merged
merged 4 commits into from
Jan 15, 2025
Merged

fix: incorrect copied state useClipboard #6585

merged 4 commits into from
Jan 15, 2025

Conversation

nileshgulia1
Copy link
Member

Fixes: Do not have a pending promise in a boolean state.

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit b8b279e
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/6784c31eb078e100087204d0

@nileshgulia1
Copy link
Member Author

@stevepiercy Any reasons why readme link-checks fails in CI?

@nileshgulia1
Copy link
Member Author

Issues :-(
> Links 
  1. [L158]  https://www.osaka-u.ac.jp/en Failed to open TCP connection to www.osaka-u.ac.jp:443 (connect(2) for "www.osaka-u.ac.jp" port 443) 
  2. [L159]  https://resou.osaka-u.ac.jp/ja Failed to open TCP connection to resou.osaka-u.ac.jp:443 (connect(2) for "resou.osaka-u.ac.jp" port 443) 

@stevepiercy
Copy link
Collaborator

@nileshgulia1 you found it, and it was temporary. Normally I contact the owner of the site, if I know who it is, usually by finding it on the blame view at https://github.com/collective/awesome-volto/blame/main/README.md.

I restarted the failed check. Let's see if it still fails.

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davisagli davisagli merged commit 6f6f98f into main Jan 15, 2025
73 checks passed
@davisagli davisagli deleted the fix-useClipboard branch January 15, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants