Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting large dataset in Dash app #267

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Plotting large dataset in Dash app #267

merged 6 commits into from
Aug 13, 2024

Conversation

bchen39
Copy link
Contributor

@bchen39 bchen39 commented Aug 12, 2024

Please also check the links to my test applications, using WebGL, plotly-resampler and the two methods combined

Closes ploomber.io#199


📚 Documentation preview 📚: https://ploomber-doc--267.org.readthedocs.build/en/267/

Copy link
Contributor

@bryannho bryannho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, one small comment

examples/dash/plotly-large-dataset/README.md Outdated Show resolved Hide resolved
@neelasha23
Copy link
Contributor

neelasha23 commented Aug 13, 2024

Please add a brief description about the app and how users need to interact with it, what output should they expect to see (somewhere at the top):

Screenshot 2024-08-13 at 10 43 56 AM

You can mention that date and time is in 24 hr format.

Also, is there an easy way to select the date/year and then displaying the corresponding time period's data? Maybe a datepicker? Right now we need to zoom out completely to view all the years.

@bchen39
Copy link
Contributor Author

bchen39 commented Aug 13, 2024

Please add a brief description about the app and how users need to interact with it, what output should they expect to see (somewhere at the top):

Screenshot 2024-08-13 at 10 43 56 AM You can mention that date and time is in 24 hr format.

Also, is there an easy way to select the date/year and then displaying the corresponding time period's data? Maybe a datepicker? Right now we need to zoom out completely to view all the years.

How about a layout like this?

Screenshot 2024-08-13 at 9 48 50 AM

I believe that I will only need to implement the date selection feature for the resampler and combined approaches since the webgl approach already filters the date you can see.

@neelasha23
Copy link
Contributor

Looks fine. Make sure to address the other points as well @bchen39

@bchen39
Copy link
Contributor Author

bchen39 commented Aug 13, 2024

Looks fine. Make sure to address the other points as well @bchen39

Description of app display and instruction on app interaction.

Added date range in resampler and combined approach. Please see updated demos of resampler and combined approaches. @neelasha23

@bchen39 bchen39 requested a review from bryannho August 13, 2024 15:08
bryannho
bryannho previously approved these changes Aug 13, 2024
Copy link
Contributor

@bryannho bryannho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@neelasha23
Copy link
Contributor

The date filters look fine but there is still no description in the app itself.
Refer to this part of the above comment:

Please add a brief description about the app and how users need to interact with it, what output should they expect to see (somewhere at the top):

You can also mention the date range of the dataset. I think it just has data for 2006? @bchen39

@bchen39
Copy link
Contributor Author

bchen39 commented Aug 13, 2024

The date filters look fine but there is still no description in the app itself. Refer to this part of the above comment:

Please add a brief description about the app and how users need to interact with it, what output should they expect to see (somewhere at the top):

You can also mention the date range of the dataset. I think it just has data for 2006? @bchen39

Ok. For clarification, by "description" you are referring to the code for app.py, the output, and how users can interact with the app. Is that correct? @neelasha23

@neelasha23
Copy link
Contributor

No need to mention any code. Just below Plotting Large Datasets in Dash you can mention very briefly that dataset contains flights data of X year - Y year (replace with exact values). What the plot represents. And that users can zoom into the plot or change date filters and view the plot update.

@bryannho
Copy link
Contributor

@bchen39 I think she means to add this description as text on the actual Dash app display, not in the readme. So that users can read it when they visit the demo

@bchen39
Copy link
Contributor Author

bchen39 commented Aug 13, 2024

Ahh ok. I will do so

@bchen39
Copy link
Contributor Author

bchen39 commented Aug 13, 2024

Let me know if this display works! @neelasha23 @bryannho

Screenshot 2024-08-13 at 1 32 29 PM

neelasha23
neelasha23 previously approved these changes Aug 13, 2024
@bchen39
Copy link
Contributor Author

bchen39 commented Aug 13, 2024

My apologies, I forgot to push the modification to the apps. Please check the updated demo. Thank you!

@edublancas edublancas merged commit 6684386 into main Aug 13, 2024
1 check passed
@edublancas edublancas deleted the plotly-large-dataset branch August 13, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants