-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plotting large dataset in Dash app #267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, one small comment
Looks fine. Make sure to address the other points as well @bchen39 |
Description of app display and instruction on app interaction. Added date range in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The date filters look fine but there is still no description in the app itself.
You can also mention the date range of the dataset. I think it just has data for 2006? @bchen39 |
Ok. For clarification, by "description" you are referring to the code for |
No need to mention any code. Just below |
@bchen39 I think she means to add this description as text on the actual Dash app display, not in the readme. So that users can read it when they visit the demo |
Ahh ok. I will do so |
Let me know if this display works! @neelasha23 @bryannho |
My apologies, I forgot to push the modification to the apps. Please check the updated demo. Thank you! |
Please also check the links to my test applications, using WebGL,
plotly-resampler
and the two methods combinedCloses ploomber.io#199
📚 Documentation preview 📚: https://ploomber-doc--267.org.readthedocs.build/en/267/