-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better checks for Changelog entries #77
Conversation
path logs logs logs logs logs logs logs logs fixed cmd fixed cmd fixed cmd fixed cmd fixed cmd fixed cmd parse entry git cmd parser parser parser parser parser restructured restructured restructured restructured test Lint tests remove binder test remove print fix test
Please review @edublancas |
@bryannho please dome some testing you can open a dummy PR in this repo to test it: https://github.com/ploomber/dummy just ensure you're installing pkgmt from the right place
if you have questions about installation and testing let us know |
@edublancas @neelasha23 Did some testing, you can see my tests here: ploomber/dummy#64 Tested these cases:
All cases work as expected except for the main one: If Another note is I had to modify |
@bryannho don't forget to perform reviews, remember that we have a 24 hours SLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neelasha23 @edublancas tested, bug fixed. looks good to me!
Closes #76