Skip to content

Commit

Permalink
remove telemetry
Browse files Browse the repository at this point in the history
  • Loading branch information
edublancas committed Sep 18, 2024
1 parent 264bb63 commit 54b5f6f
Show file tree
Hide file tree
Showing 8 changed files with 3 additions and 46 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## 0.0.33dev

* [Feature] Remove telemetry

## 0.0.32 (2024-02-07)

* [Feature] Add benchmarking CLI `python -m ploomber_engine.benchmark`
Expand Down
4 changes: 0 additions & 4 deletions doc/community/support.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
# Support

For support, feature requests, and product updates: [join our community](https://ploomber.io/community) or follow us on [Twitter](https://twitter.com/ploomber)/[LinkedIn](https://www.linkedin.com/company/ploomber/).

# Telemetry

We collect (optional) anonymous statistics to understand and improve usage. For details, [see here](https://docs.ploomber.io/en/latest/community/user-stats.html).
14 changes: 0 additions & 14 deletions src/ploomber_engine/_telemetry.py

This file was deleted.

4 changes: 0 additions & 4 deletions src/ploomber_engine/engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,12 @@

from ploomber_engine.papermill import PapermillPloomberNotebookClient
from ploomber_engine.ipython import PloomberManagedClient
from ploomber_engine._telemetry import telemetry


class DebugEngine(Engine):
"""An engine that starts a debugging session once the notebook fails"""

@classmethod
@telemetry.log_call("debug-execute-managed-nb")
def execute_managed_notebook(
cls,
nb_man,
Expand Down Expand Up @@ -57,7 +55,6 @@ class DebugLaterEngine(Engine):
"""An engine that stores the traceback object for later debugging"""

@classmethod
@telemetry.log_call("debuglater-execute-managed-nb")
def execute_managed_notebook(
cls,
nb_man,
Expand Down Expand Up @@ -118,7 +115,6 @@ class ProfilingEngine(Engine):
"""

@classmethod
@telemetry.log_call("embedded-execute-managed-nb")
def execute_managed_notebook(
cls,
nb_man,
Expand Down
4 changes: 0 additions & 4 deletions src/ploomber_engine/execute.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,8 @@
from ploomber_engine.ipython import PloomberClient
from ploomber_engine import profiling
from ploomber_engine import _util
from ploomber_engine._telemetry import telemetry


@telemetry.log_call(
log_args=True, ignore_args={"input_path", "output_path", "parameters"}
)
def execute_notebook(
input_path,
output_path,
Expand Down
3 changes: 1 addition & 2 deletions src/ploomber_engine/profiling.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

from ploomber_engine.ipython import PloomberClient
from ploomber_engine._util import recursive_update
from ploomber_engine._telemetry import telemetry


try:
import psutil
Expand Down Expand Up @@ -43,7 +43,6 @@ def hook_cell_post(self, cell):
recursive_update(cell.metadata, metadata)


@telemetry.log_call("memory-profile")
def memory_profile(path, output):
path = Path(path)
target = path.with_name(path.stem + "-memory-usage.png")
Expand Down
2 changes: 0 additions & 2 deletions src/ploomber_engine/tracking/tracking.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

from ploomber_engine.ipython import PloomberClient, add_to_sys_path
from ploomber_engine.tracking.io import _process_content_data
from ploomber_engine._telemetry import telemetry
from ploomber_engine._util import find_cell_with_parameters_comment

try:
Expand Down Expand Up @@ -161,7 +160,6 @@ def _parse_cli_parameters(parameters):
return {k: _parse_param(v) for k, v in pairs}


@telemetry.log_call("track-execution")
def track_execution(filename, parameters=None, database="experiments.db", quiet=False):
"""
Execute a script or notebook and write outputs to a SQLite database
Expand Down
16 changes: 0 additions & 16 deletions tests/test_tracking.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from ploomber_engine.tracking.tracking import _parse_cli_parameters, extract_name
from ploomber_engine.tracking import track_execution
from sklearn_evaluation import SQLiteTracker
from ploomber_engine import _telemetry


@pytest.mark.parametrize(
Expand Down Expand Up @@ -297,18 +296,3 @@ def sum_(args):
)
def test_extract_name(source, expected):
assert extract_name(source) == expected


def test_tracking_import_telemetry(tmp_empty, monkeypatch):
Path("functions.py").write_text("""x = 1""")
mock = Mock()
monkeypatch.setattr(_telemetry.telemetry, "log_api", mock)

track_execution(
filename="functions.py",
parameters=dict(a=1, b=2),
database="exps.db",
quiet=True,
)

assert mock.call_count == 1

0 comments on commit 54b5f6f

Please sign in to comment.