Single wildcards output fix #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
💃 Looks great.
If you felt like being extra-paranoid with tests (but I don't think this is necessary for this PR) there are a couple more cases we could in principle cover:
- Both in the single- and multi-output cases, have
ALLmatch only a single element. Note this could be done by creating a new request to the same apps as in the new test and the one you just clarified the name, as we can assume the layout was changed as a result of some other callback. - A real multi-output callback, where one output is a regular string ID and the other one is an
ALLthat matches no elements at all, such that the callback should return an empty list for that second output. Note that if it's a single-output callback with just anALLthat matches no elements, the callback will never be triggered.
I created the #142 so as not to forget |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More accurate work with single
Output. Fixes #84