Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed deprecated dependencies that are now integrated #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions demos/pyvista-terrain-following-mesh/app.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import dash
from dash import dcc, html, Input, Output
Comment on lines 1 to +2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nonblocking, but some styleguides/linters complain that this is a duplicate import. This is why most of our examples now explicitly import everything you're going to use - in this case that would add Dash and no_update which then lose the dash. prefix below - so you can drop the plain import dash.

import dash_vtk
import dash_bootstrap_components as dbc
import dash_html_components as html
import dash_core_components as dcc
from dash.dependencies import Input, Output, State
#import dash_html_components as html
#import dash_core_components as dcc
#from dash.dependencies import Input, Output, State

import random
import json
Expand Down