adding support for async callbacks and page layouts #3089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSd3v
requested review from
alexcjohnson,
T4rk1n,
ndrezn,
gvwilson and
emilykl
as code owners
…ayouts reference this in order to determine whether or not they should load as async functions.
…ing at the function to determine
…r testing and not relying on a specific string to be present as a comment
…e as `async`. Added more defined error messages when libraries are missing or async was used without async turned on.
…ing the clearing input values to make sure that we were only triggering callbacks when we desired.
…eck for async and wrapping a view.
…being cleared allows the failed integrations to pass
…t name to note if the image is `async` vs default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is attempting to allow for layouts and callbacks to be performed in a way that will allow for async functions natively.