-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: adding type annotations to some constructor parameters
Using `get_typing_type` from `codegen/datatypes.py` to add Python datatype to some constructor parameters. Notes: 1. Does not handle the `compound` datatype yet. `get_typing_type` raises a `ValueError` because it doesn't have a clause for this type; `add_constructor_params` catches this and simply doesn't add a type definition. Something between a third and half of all constructor parameters suffer from this, so we need to figure out what `compound` means and define a type for it. 2. Almost all parameters are nullable, so the type is defined as (for example) `int` but the default value assigned is `None`.
- Loading branch information
Showing
1,010 changed files
with
15,648 additions
and
15,644 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.