-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin test requirements #5019
Open
marthacryan
wants to merge
37
commits into
main
Choose a base branch
from
unpin-requirements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Unpin test requirements #5019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6862255
to
c2af57b
Compare
emilykl
reviewed
Feb 11, 2025
faa3d7c
to
d282c49
Compare
c383ac0
to
f780164
Compare
emilykl
reviewed
Feb 13, 2025
- "3.12" | ||
name: "Test optional with python << parameters.python_version >>" | ||
- test_optional_py: | ||
name: "Test optional with pandas 1.2.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
name: "Test optional with pandas 1.2.4" | |
name: "Test optional with python << parameters.python_version >> and pandas << parameters.pandas_version >>" |
(does this work?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately it doesn't look like the other one is working so I don't think we can actually use this here :(
LiamConnors
reviewed
Feb 17, 2025
be9ae8f
to
2a63724
Compare
Narwhals is already bundled with plotly.py, so users shouldn't have to install it themselves
emilykl
reviewed
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
feature
something new
P1
needed for current cycle
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plotly/tools.py