Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin test requirements #5019

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Unpin test requirements #5019

wants to merge 37 commits into from

Conversation

marthacryan
Copy link
Collaborator

@marthacryan marthacryan commented Feb 7, 2025

  • Replaces the separated files which pinned different versions of packages for each version of python with two files that list the unpinned requirements for core / optional tests
  • Updates the CI config to be more parameterized
  • Removes the no numpy tests - it turns out that it wasn't actually testing without numpy, and since we added narwhals our tests do in fact fail without numpy
  • Removes orca tests from config
  • Adds uv into a couple of more spots to speed up the dependency downloads
  • Removes unused commit step from plotly.js dev build job
  • Removes unused import of ipython and sage salvus in plotly/tools.py

@gvwilson gvwilson added feature something new P1 needed for current cycle dependencies Pull requests that update a dependency file labels Feb 10, 2025
@marthacryan marthacryan marked this pull request as ready for review February 11, 2025 21:49
@marthacryan marthacryan requested a review from emilykl February 13, 2025 02:06
- "3.12"
name: "Test optional with python << parameters.python_version >>"
- test_optional_py:
name: "Test optional with pandas 1.2.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: "Test optional with pandas 1.2.4"
name: "Test optional with python << parameters.python_version >> and pandas << parameters.pandas_version >>"

(does this work?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it doesn't look like the other one is working so I don't think we can actually use this here :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file feature something new P1 needed for current cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants