- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.7k
create_hexbin_mapbox uses *_map chart types instead of *_mapbox #5358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
      
        
          +56
        
        
          −37
        
        
          
        
      
    
  
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            10 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      7c589f8
              
                Refactored create_hexbin_mapbox to use *_map chart types instead of *…
              
              
                ajlien b9a271d
              
                Updated create_hexbin_mapbox docstring
              
              
                ajlien 565a92c
              
                Merge branch 'main' into update-hexbin-map-no-mapbox
              
              
                emilykl cd2d4ad
              
                Renamed create_hexbin_mapbox to create_hexbin_map
              
              
                ajlien bd178f6
              
                Ruff formatting
              
              
                ajlien 5b38811
              
                Merge branch 'main' into update-hexbin-map-no-mapbox
              
              
                ajlien dd3bd89
              
                More ruff formatting
              
              
                ajlien ebb6209
              
                Merge branch 'update-hexbin-map-no-mapbox' of github.com:ajlien/plotl…
              
              
                ajlien 4d8fbc4
              
                Updated figure factory init
              
              
                ajlien 9773b5f
              
                Removed Mapbox-related content from hexbin examples
              
              
                ajlien File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|  | @@ -29,12 +29,18 @@ | |||||||||||||||
|  | ||||||||||||||||
| if optional_imports.get_module("pandas") is not None: | ||||||||||||||||
| from plotly.figure_factory._county_choropleth import create_choropleth | ||||||||||||||||
| from plotly.figure_factory._hexbin_mapbox import create_hexbin_mapbox | ||||||||||||||||
| from plotly.figure_factory._hexbin_map import ( | ||||||||||||||||
| create_hexbin_map, | ||||||||||||||||
| create_hexbin_mapbox, | ||||||||||||||||
| ) | ||||||||||||||||
| else: | ||||||||||||||||
|  | ||||||||||||||||
| def create_choropleth(*args, **kwargs): | ||||||||||||||||
| raise ImportError("Please install pandas to use `create_choropleth`") | ||||||||||||||||
|  | ||||||||||||||||
| def create_hexbin_map(*args, **kwargs): | ||||||||||||||||
| raise ImportError("Please install pandas to use `create_hexbin_map`") | ||||||||||||||||
| 
      Comment on lines
    
      +41
     to 
      +42
    
   There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 
        Suggested change
       
 | ||||||||||||||||
|  | ||||||||||||||||
| def create_hexbin_mapbox(*args, **kwargs): | ||||||||||||||||
| raise ImportError("Please install pandas to use `create_hexbin_mapbox`") | ||||||||||||||||
|  | ||||||||||||||||
|  | @@ -57,6 +63,7 @@ def create_ternary_contour(*args, **kwargs): | |||||||||||||||
| "create_distplot", | ||||||||||||||||
| "create_facet_grid", | ||||||||||||||||
| "create_gantt", | ||||||||||||||||
| "create_hexbin_map", | ||||||||||||||||
|         
                  emilykl marked this conversation as resolved.
              Show resolved
            Hide resolved | ||||||||||||||||
| "create_hexbin_mapbox", | ||||||||||||||||
| "create_ohlc", | ||||||||||||||||
| "create_quiver", | ||||||||||||||||
|  | ||||||||||||||||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove the
px.set_mapbox_access_token(open(".mapbox_token").read())lines in these examples and the information about mapbox tokens in the introduction.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 9773b5