Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks, thanks for building this project 🦀
I ran into an
index out of bounds
error when playing around with the blit_bitmap example when using theSvgBackend
instead of theBitmapBackend
:blit_bitmap
receives dimensionsiw, ih
as parameters, but also callsget_size()
to retrieve the size of theDrawingBackend
w, h
to check whether or not the image is being drawn out of bounds (I think)w
was used instead ofiw
The attached change fixes this, though I'm not entirely sure whether the fix takes everything into account 🤔