-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right click to open search item's object inspector. Allow panel tabs … #1925
Closed
alcomposer
wants to merge
9
commits into
plugdata-team:develop
from
alcomposer:search-overview-inspector
Closed
Right click to open search item's object inspector. Allow panel tabs … #1925
alcomposer
wants to merge
9
commits into
plugdata-team:develop
from
alcomposer:search-overview-inspector
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcomposer
force-pushed
the
search-overview-inspector
branch
2 times, most recently
from
November 1, 2024 09:24
a13a1a0
to
9acc047
Compare
…to stay open if inspector was open.
…struction (objects need to call resize before their position / size is updated)
alcomposer
force-pushed
the
search-overview-inspector
branch
from
November 3, 2024 04:27
3b74988
to
2aa57dd
Compare
Conflicts: Libraries/pure-data Source/PluginEditor.cpp
dromer
reviewed
Nov 7, 2024
@@ -1144,9 +1147,9 @@ void Canvas::mouseDown(MouseEvent const& e) | |||
} | |||
|
|||
// Update selected object in sidebar when we click a object | |||
if (source && source->findParentComponentOfClass<Object>()) { | |||
//if (source && source->findParentComponentOfClass<Object>()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now it updates all the time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I use a different system now to check if the selection has changed. So I can revert this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to stay open if inspector was open.