sequel integration fix #350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 21, 2016 16:28
…fault is db, :ruby_default is ruby)
|
Can this be merged? It is generating unnecessary warnings for me as well. Example on a state column with default value "Draft". Postgresql returns 'Draft'::text, so this is what is returned and being use to compare against "Draft". Which is not correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing fetching default state from db column (:de…fault is db, :ruby_default is ruby)
This was generating an unnecessary warning. This is because sequel (I don't know since when, but long ago) loads column info defaults in db format and ruby format