-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3] add type hints to function signatures #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stklcode
changed the title
[WIP] [v3] add type hints and extend documentation
[WIP] [v3] add type hints to interfaces and base classes
Mar 18, 2024
stklcode
force-pushed
the
v3-hints
branch
3 times, most recently
from
March 23, 2024 10:08
ba3f203
to
6576f6c
Compare
stklcode
force-pushed
the
v3-hints
branch
2 times, most recently
from
March 24, 2024 09:45
813c36f
to
59fc283
Compare
Types are now checked at function call, so we can assume the type is always correct at time of execution.
stklcode
changed the title
[WIP] [v3] add type hints to interfaces and base classes
[v3] add type hints to function signatures
Mar 24, 2024
florianbrinkmann
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #575, #576 and #579 (all merged)
We have nullable and void return types, so we can annotate almost every method (some union and mixed types missing, those are PHP 8 features)
??
) where applicableFixed 2 minor bugs that came up during this refactoring:
Linkback::process()
$implements_interface
is initialized inComponentHelper