[Feature] Notification target ticket #943
Conversation
Created a new method findContainers() (based on findContainer()) that returns all 'dom' containers for an item based on its entity (with parent entity handling via getAncestorsOf()).
Adapted hooks (pre_item_add, pre_item_update, post_item_add, post_item_update) to manage multiple containers using the _plugin_fields_data_multi array.
Updated the populateData() function to extract input values by stripping the prefix, ensuring that data is saved into the correct columns of the injection table.
Modified the container.form.php file to "clean" the form data (by removing the prefix) before calling updateFieldsValues(), thereby enabling the saving of domtab containers.
This PR provides the ability to define multiple "Insertion in the form" blocks for the same item based on its entity by leveraging the new findContainers() method and adapting the save process.
…oving the prefix) before calling updateFieldsValues(), thereby enabling the saving of domtab containers.
- Inject ##fields.<container_name>.<field_name>## placeholders into ticket notifications
- Added missing @var annotation for global $DB - Replaced empty() on $entityIds with count() - Removed redundant is_array() check on $entityRestriction - Simplified isset() condition by removing unnecessary !== null check
|
@JeremieMercier, composer installThen run the fixer: vendor/bin/php-cs-fixer fix .As for PHPStan, there is no automatic fixer. However, you can analyze the code locally and inspect the reported issues using: vendor/bin/phpstan analyze |
Note: PHPStan still reports a type error on DB::request() (expects array<string>|string), but this issue already exists elsewhere in the file and was not introduced by this change.
|
I have updated the PR with the latest changes from PR 941 |
|
The feature you are proposing is very interesting and introduces a significant feature. . To ensure its smooth integration and functionality, we must be extremely vigilant. This means we need to "lock down" our testing to guarantee that everything works as expected. All types of fields must be tested from a tag on a notification to ensure the rendering of values from the plugin (as well as the label, which depends on the user's language, such as FR/EN, etc.). |
Checklist before requesting a review
Please delete options that are not relevant.
Description
This PR adds support for injecting dynamic custom field values into GLPI's ticket notification templates.