Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print downloaded file size. #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smimram
Copy link

@smimram smimram commented Jan 24, 2022

Since we have the downloaded file size, let's print it: it is useful in order to estimate how much downloading is still required (ideally we should have a progress bar, but this is already an improvement).

@valerio-bozzolan
Copy link
Contributor

I tried this patch on my computer and it just works as expected. Example output on my computer:

/download.py "https://example.com/playback/presentation/2.0/playback.html?meetingId=e420724e96d095a1510420cdc783fa50f0aee67a-1678267846906" test

Downloading https://example.com/presentation/e420724e96d095a1510420cdc783fa50f0aee67a-1678267846906/slides_new.xml (8560 bytes)...
Downloading https://example.com/presentation/e420724e96d095a1510420cdc783fa50f0aee67a-1678267846906/video/webcams.webm (373897405 bytes)...

I suggest in merging it.

(I'm not the maintainer)

@valerio-bozzolan
Copy link
Contributor

valerio-bozzolan commented Mar 3, 2024

Premising that I've done some code review, and I'm merging what I like in this fork:

https://github.com/valerio-bozzolan/bbb-render

Hoping to be useful, this pull request was merged in that fork, at this point:

valerio-bozzolan@b427d05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants