Add logo to OpenDNS #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The index.html file should be regenerated by invoking |
|
Will do, thanks for the help! I will update the pill request tomorrow. |
|
Ready for review again @plujon. |
|
If OpenDNS doesn't have a canonical url for their logo, it seems better to put the image in iconcache than to use an image sharing service. |
|
Image cache. Okay. I will do so. |
plujon
force-pushed
the
master
branch
2 times, most recently
from
e6ee0a4 to
5825ed4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple logo to the OpenDNS entry. I will be adding more soon.
I also want to ask this: do I have to modify both the index.html file and this file? Or this this sufficient?