Wi-Fi Association Bug Fix for BCM #2
Conversation
|
Hi @Roy-Vincent @kazikcz can you please provide your view as WiFI OpenSync Architect on this PR request? Thanks! |
There was a problem hiding this comment.
The commit log must not be empty. Commit log must describe why the change is necessary, and if it does something that may not be immediately obvious to the reader, why it is done in a particular way. It needs to describe what the system behavior was before and after the change. If it's a bug, it needs to explain what the conditions for the bug were.
As it is, I don't understand anything about this change.
| }else{ | ||
| //Adding a log here would be helpful to inform the developer/integrator | ||
| bcmwl_vap_prealloc(p->d_name, bssmax - 2, bcmwl_vap_mac_xfrm); | ||
| } |
There was a problem hiding this comment.
- Formatting does not match the existing style. This needs to be fixed.
- bssmax will never be greater than 8 by default - the BCMWL_VAP_PREALLOC_MAX is already 8, and will limit bssmax to be 8 at most. Are you building opensync with modified BCMWL_VAP_PREALLOC_MAX? If so, to what value, and why?
- Why are you checking bssmax against 8 in particular? Why not 7 or 9?
- Why are you decrementing 1 or 2 depending on the condition result? How is this helping, and why is this helping with "Wi-Fi Association Bug".
- What is the bug that you're really fixing? Can you describe what you do, and what you see, and what you expect?
while integrating opensync 6.2 with BCM 5.04.04p3 it was observed that the extender devices could not associate with the onboard AP.
Further analysis revealed that the SDK was set to the default value for BSS (bssmax = 8). Since opensync was trying to bring up interfaces ranging from wlx.1 to wlx.7 by default, there was some conflict that caused the failure in the leaf association.
The following fix addresses the issue if the SDK comes with default values, the leaf will still be able to associate with the GW and bring up the APs. The VIFs wlx.1 to wlx.6 will be brought up in this case.
This can help with the normal operation of the leaf device. However, it will be better to request the ODM for this requirement (bssmax at least 10) in intake form / TRD when they approach for Integration/Certification with the plume team.