Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dagster): upgrade dagster #488

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix(dagster): upgrade dagster #488

merged 1 commit into from
Jul 9, 2024

Conversation

walkoss
Copy link
Contributor

@walkoss walkoss commented Jul 5, 2024

Summary

Updated dagster's user code container with latest version

Test Plan

Build docker image locally

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 5, 2024
View reviewed changes
dagster/Dockerfile
@@ -1,4 +1,4 @@
FROM docker.io/dagster/user-code-example:1.7.7
FROM docker.io/dagster/user-code-example:1.7.12

Check failure

Code scanning / Trivy

Image user should not be 'root' High

Artifact: dagster/Dockerfile
Type: dockerfile
Vulnerability DS002
Severity: HIGH
Message: Specify at least 1 USER command in Dockerfile with non-root user as argument
Link: DS002
dagster/Dockerfile
@@ -1,4 +1,4 @@
FROM docker.io/dagster/user-code-example:1.7.7
FROM docker.io/dagster/user-code-example:1.7.12

Check notice

Code scanning / Trivy

No HEALTHCHECK defined Low

Artifact: dagster/Dockerfile
Type: dockerfile
Vulnerability DS026
Severity: LOW
Message: Add HEALTHCHECK instruction in your Dockerfile
Link: DS026
@walkoss walkoss mentioned this pull request Jul 5, 2024
Open
16 tasks
@michaeljguarino michaeljguarino merged commit 5ac9dec into pluralsh:main Jul 9, 2024
2 of 3 checks passed
@plural-bot
Copy link
Collaborator

🎉 This PR is included in version 1.3.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@walkoss @plural-bot @michaeljguarino