Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve imports from services #300

Merged
merged 1 commit into from
Oct 14, 2024
Merged

feat: resolve imports from services #300

merged 1 commit into from
Oct 14, 2024

Conversation

zreigz
Copy link
Member

@zreigz zreigz commented Oct 14, 2024

No description provided.

@zreigz zreigz changed the title resolve imports from services feat: resolve imports from services Oct 14, 2024
@zreigz zreigz added the enhancement New feature or request label Oct 14, 2024
for _, imp := range svc.Imports {
res[imp.Stack.Name] = map[string]string{}
for _, out := range imp.Outputs {
res[imp.Stack.Name][out.Name] = out.Value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

output values are always strings currently? We probably should document that when it's time to.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to the schema the output values are always strings

@zreigz zreigz merged commit d70cf61 into main Oct 14, 2024
30 of 32 checks passed
@zreigz zreigz deleted the imports-from-services branch October 14, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants