Skip to content

Commit

Permalink
Upgrade retool, fix dagster oidc setup
Browse files Browse the repository at this point in the history
We need to get retool onto latest, and realized dagster isn't using the current reusable oidc config (which makes basic auth nontrivial to configure), so fixing that as well.
  • Loading branch information
michaeljguarino committed Dec 18, 2023
1 parent 1231cdc commit 29ad076
Show file tree
Hide file tree
Showing 11 changed files with 40 additions and 64 deletions.
7 changes: 5 additions & 2 deletions dagster/helm/dagster/Chart.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ dependencies:
- name: postgres
repository: https://pluralsh.github.io/module-library
version: 0.1.16
- name: oidc-config
repository: https://pluralsh.github.io/module-library
version: 0.1.6
- name: dagster
repository: https://dagster-io.github.io/helm
version: 1.5.4
Expand All @@ -11,5 +14,5 @@ dependencies:
- name: test-base
repository: https://pluralsh.github.io/module-library
version: 0.1.10
digest: sha256:429db54a06ff1d43d546fb5b8da1534e7f06f12a0e408a83e146222eb2585cbb
generated: "2023-10-20T10:53:15.243597+02:00"
digest: sha256:711eb99a3aa598dc5755698003710c6e4f175f99cfbf68589e27fbb19ef1a6b0
generated: "2023-12-18T10:52:48.079022-05:00"
4 changes: 4 additions & 0 deletions dagster/helm/dagster/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ dependencies:
- name: postgres
version: 0.1.16
repository: https://pluralsh.github.io/module-library
- name: oidc-config
version: 0.1.6
repository: https://pluralsh.github.io/module-library
condition: oidc-config.enabled
- name: dagster
version: 1.5.4
repository: https://dagster-io.github.io/helm
Expand Down
Binary file added dagster/helm/dagster/charts/oidc-config-0.1.6.tgz
Binary file not shown.
49 changes: 0 additions & 49 deletions dagster/helm/dagster/templates/oidc.yaml

This file was deleted.

12 changes: 12 additions & 0 deletions dagster/helm/dagster/values.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
global:
serviceAccountName: dagster

oidc-config:
enabled: false
service:
name: dagster-oauth2-proxy
selector:
app.kubernetes.io/instance: dagster
component: dagster-webserver
secret:
env:
OAUTH2_PROXY_UPSTREAM_TIMEOUT: '120s'


postgres:
team: plural
user: dagster
Expand Down
18 changes: 12 additions & 6 deletions dagster/helm/dagster/values.yaml.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,19 @@ postgres:
password: {{ $postgresPwd }}

{{ if .OIDC }}
oidcProxy:
{{ $prevSecret := dedupe . "dagster.oidcProxy.cookieSecret" (randAlphaNum 32) }}
oidc-config:
enabled: true
upstream: http://localhost:80
issuer: {{ .OIDC.Configuration.Issuer }}
clientID: {{ .OIDC.ClientId }}
clientSecret: {{ .OIDC.ClientSecret }}
cookieSecret: {{ dedupe . "dagster.oidcProxy.cookieSecret" (randAlphaNum 32) }}
secret:
name: dagster-proxy-config
issuer: {{ .OIDC.Configuration.Issuer }}
clientID: {{ .OIDC.ClientId }}
clientSecret: {{ .OIDC.ClientSecret }}
cookieSecret: {{ dedupe . "dagster.oidc-config.secret.cookieSecret" $prevSecret }}
{{ if .Values.users }}
users:
{{ toYaml .Values.users | nindent 4 }}
{{ end }}
{{ end }}

dagster:
Expand Down
6 changes: 3 additions & 3 deletions retool/helm/retool/Chart.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ dependencies:
version: 0.1.5
- name: retool
repository: https://charts.retool.com
version: 6.0.2
digest: sha256:64e43f4c30b1d885101d9c50fe2f314e54f86d33e555ba6df3d9b90dda8784d4
generated: "2023-09-26T12:08:59.73891-04:00"
version: 6.0.11
digest: sha256:c182bac59d78a9f260acb187063a7ffbfff0b887fc81a383959c88b22a03e337
generated: "2023-12-18T10:33:05.569756-05:00"
6 changes: 3 additions & 3 deletions retool/helm/retool/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ apiVersion: v2
name: retool
description: helm chart for retool
type: application
version: 0.1.7
appVersion: "v3.12.2"
version: 0.1.8
appVersion: "v3.24.1"
dependencies:
- name: postgres
version: 0.1.5
repository: https://pluralsh.github.io/module-library
- name: retool
version: 6.0.2
version: 6.0.11
repository: https://charts.retool.com
Binary file added retool/helm/retool/charts/retool-6.0.11.tgz
Binary file not shown.
Binary file removed retool/helm/retool/charts/retool-6.0.2.tgz
Binary file not shown.
2 changes: 1 addition & 1 deletion retool/helm/retool/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ retool:

image:
repository: tryretool/backend
tag: 3.12.2
tag: 3.24.1

workflows:
temporal:
Expand Down

0 comments on commit 29ad076

Please sign in to comment.