✨ Lakefs #309
Merged
✨ Lakefs #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michaeljguarino please let me know if need to modify the terraform files because the actual LakeFS terraform script has to be different with more setup. |
| - name: JCLOUDS_PROVIDER | ||
| value: s3 | ||
| - name: JCLOUDS_ENDPOINT | ||
| value: https://s3.amazonaws.com |
There was a problem hiding this comment.
my guess is making this work for gcp/azure might require additional configuration here
| - name: lakefs | ||
| configuration: | ||
| - name: hostname | ||
| documentation: domain on which you'd like to host lakefs's page |
There was a problem hiding this comment.
perhaps:
dns name for the lakefs web ui
| - name: lakefs | ||
| configuration: | ||
| - name: hostname | ||
| documentation: domain on which you'd like to host lakefs's page |
| - name: lakefs | ||
| configuration: | ||
| - name: hostname | ||
| documentation: domain on which you'd like to host lakefs's page |
| {{- include "lakefs.labels" . | nindent 4 }} | ||
| type: Opaque | ||
| data: | ||
| database_connection_string: {{ .Values.secrets.databaseConnectionString | default "" | b64enc }} |
There was a problem hiding this comment.
I'm not sure I see where these are being set currently
|
my guess is you'll need to add some terraform to create the s3/gcs/etc buckets too, but I'm not sure about lakefs' details, it's possible that's resolved in the application itself |
|
I'll merge this to unblock the chicken-egg for publishing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lakefs onboarding (#305), initial push for testing