Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: onboard unleash #650

Merged
merged 3 commits into from
Apr 15, 2023
Merged

feat: onboard unleash #650

merged 3 commits into from
Apr 15, 2023

Conversation

walkoss
Copy link
Contributor

@walkoss walkoss commented Apr 15, 2023

Summary

Test Plan

  • Deployed helm chart + terraform locally

Checklist

  • No images hosted from dockerhub
  • Are dashboards present to understand the health of the application. There must be at least 1 of these
    • all databases should have dashboards
    • ideally also have at least cpu/mem utilization dashboards for webserver tier of the app
    • you can use plural from-grafana to convert a grafana dashboard found via google to our CRD
  • Are scaling runbooks present
    • all databases must have scaling runbooks
    • you can use the charts in pluralsh/module-library to accelerate this
  • do you need to add config overlays?
    • inputing secrets
    • configuring autoscaling
  • If there’s a web-facing component to the app, we need to support OIDC authentication and setting up private networks if no authentication option is viable
  • All major clouds must be supported
    • Azure
    • AWS
    • GCP

@michaeljguarino
Copy link
Member

I suspect using the oauth proxy might also require oauth for the feature flag apis and some workaround will be needed there, probably w/ adding a dedicated ingress path for them

@michaeljguarino michaeljguarino merged commit 5de9d0a into pluralsh:main Apr 15, 2023
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@walkoss
Copy link
Contributor Author

walkoss commented Apr 15, 2023

I suspect using the oauth proxy might also require oauth for the feature flag apis and some workaround will be needed there, probably w/ adding a dedicated ingress path for them

Good catch, I'll fix it
Should we always have OIDC support? Unleash has a auth system already

@michaeljguarino
Copy link
Member

I don't think it's necessary to always enable oidc, what you can do is have a dedicated path for the flag apis that are exposed publicly that routes to a service that is directed to the regular unleash container ports instead of the oauth proxy ones

@walkoss walkoss deleted the feat/unleash branch April 15, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants