adding functionality to return just the instance_id #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgraded the readme to incorporate the changes that I added for SSM as well as the --id-only
jwhaley58
commented
Feb 28, 2021
| @@ -91,7 +91,11 @@ def entrypoint(use_private_ip, key_path, user, ip_only, no_cache, tunnel, tunnel | |||
|
|
|||
| chosen_host = choice(fuzzysearch_bash_command, use_ssm) | |||
|
|
|||
| if use_ssm or ENV_USE_SSM: | |||
| if ENV_USE_SSM or use_ssm: | |||
| if id_only: | |||
There was a problem hiding this comment.
There is a known gap here, if you don't pass --ssm then you can't get to this branch of the code. I looked into using the click library to make dependent variables. It doesn't seem like it's something that works easily out of the box.
I'm open to making this more robust or adding exception handling but I didn't see a lot of that in this project and decided to just stick with simple.
|
this will resolve #41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgraded the readme to incorporate the changes that I added for SSM as well as the --id-only