Skip to content
This repository has been archived by the owner on May 22, 2023. It is now read-only.

Run create build step on opened _or_ sync actions #23

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Run create build step on opened _or_ sync actions #23

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
86fe107
opened or sync
rawestmoreland Jun 17, 2022
5f202c6
new step
rawestmoreland Jun 18, 2022
ef414fc
typo
rawestmoreland Jun 18, 2022
8b20e4c
output url
rawestmoreland Jun 18, 2022
77d8c77
quote
rawestmoreland Jun 18, 2022
ad7088b
object
rawestmoreland Jun 18, 2022
b42ab5c
while loop
rawestmoreland Jun 19, 2022
708db48
add logging
rawestmoreland Jun 19, 2022
c72e43d
check for null
rawestmoreland Jun 19, 2022
967d870
remove prettierrc
rawestmoreland Jun 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ runs:
-H "Accept: application/vnd.heroku+json; version=3" \
-H "Authorization: Bearer ${{ inputs.api-key }}"
- name: Create Build
if: ${{ github.event_name == 'pull_request' && github.event.action == 'synchronize' }}
if: ${{ github.event_name == 'pull_request' && (github.event.action == 'opened' || github.event.action == 'synchronize') }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't change. When a review app is created, it automatically has a build process going on. So from the Create App step we can use the data returned to find the output stream URL and curl that URL like it's done in Create Build step.

shell: bash
run: |
export SOURCE_GET_URL=$(echo ${{ toJSON(steps.source_endpoint.outputs.SOURCE_ENDPOINT) }} | jq -r '.get')
Expand Down