ndctl: fix ndctl linking with libkeyutils

Compilation on Ubuntu 18.04 fails with: /usr/bin/ld: util/keys.o: undefined reference to symbol 'keyctl_read_alloc@@KEYUTILS_0.3' /lib/x86_64-linux-gnu/libkeyutils.so.1: error adding symbols: DSO missing from command line Seems like libkeyutils is incorrectly linked against libndctl, where in reality it's the ndctl application that uses keyutils. Fixes: 86b078b ("ndctl: add passphrase management commands") Cc: Dave Jiang <[email protected]> Signed-off-by: Piotr Balcer <[email protected]> Reviewed-by: Dave Jiang <[email protected]> Signed-off-by: Vishal Verma <[email protected]>
pmem · Feb 5, 2019 · d1cc2b6 · d1cc2b6
1 parent 8ca46ad
commit d1cc2b6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ndctl/Makefile.am b/ndctl/Makefile.am
@@ -47,6 +47,10 @@ ndctl_LDADD =\
 	$(KMOD_LIBS) \
 	$(JSON_LIBS)
 
+if ENABLE_KEYUTILS
+ndctl_LDADD += -lkeyutils
+endif
+
 if ENABLE_TEST
 ndctl_SOURCES += ../test/libndctl.c \
 		 ../test/dsm-fail.c \

diff --git a/ndctl/lib/Makefile.am b/ndctl/lib/Makefile.am
@@ -30,10 +30,6 @@ libndctl_la_LIBADD =\
 	$(UUID_LIBS) \
 	$(KMOD_LIBS)
 
-if ENABLE_KEYUTILS
-libndctl_la_LIBADD += -lkeyutils
-endif
-
 EXTRA_DIST += libndctl.sym
 
 libndctl_la_LDFLAGS = $(AM_LDFLAGS) \