Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed double declaration and assignment #111

Merged
merged 6 commits into from
Aug 21, 2024
Merged

removed double declaration and assignment #111

merged 6 commits into from
Aug 21, 2024

Conversation

yutiPML
Copy link
Collaborator

@yutiPML yutiPML commented Jul 6, 2023

Description of Work

Fixes

Testing Instructions

@yutiPML yutiPML requested a review from glessin July 6, 2023 15:37
@yutiPML yutiPML linked an issue Jul 6, 2023 that may be closed by this pull request
double diagnostic in nitrification.F90 #110
Closed
glessin
glessin reviewed Jul 7, 2023
View reviewed changes
Copy link
Member

@glessin glessin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change line 60: 'rate' to 'nitrification rate' (both name and long_name) and add 'N' to units (i.e. 'mmol N').
But maybe we better keep the id_N4N3n rather than 'id_nitrification' for consistency with N4O5n?

@wathen
Copy link
Member

wathen commented Jul 16, 2024

@yutiPML and @glessin, is this ready for review? Also, is there an issue number to add to the PR?

@yutiPML yutiPML marked this pull request as draft July 24, 2024 10:13
@yutiPML yutiPML marked this pull request as ready for review July 24, 2024 11:44
@glessin glessin merged commit 9dcbee9 into master Aug 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glessin glessin glessin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

double diagnostic in nitrification.F90
3 participants
@yutiPML @wathen @glessin