Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding minimum and maximum values to get_parameters in ERSEM #139

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adding minimum and maximum values to get_parameters in ERSEM #139

wants to merge 5 commits into from

Conversation

wathen
Copy link
Member

@wathen wathen commented Aug 5, 2024 •
edited
Loading

Description of Work

Fixes #138

Adds parameter checks in the code to make sure that you can't use invalid parameters

Testing Instructions

  1. Check through src/*F90 to make sure all parameters that need them have checks
  2. Download and build code to run to make sure that parameter checks work

@wathen wathen marked this pull request as ready for review August 6, 2024 11:24
@wathen wathen requested a review from hpowley August 6, 2024 11:24
hpowley
hpowley reviewed Aug 9, 2024
View reviewed changes
Copy link
Member

@hpowley hpowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Denit in bacteria_docdyn.F90 needs a max/min.
source_depth_distribution in benthic_column_particulate_matter.F90 needs max/min
Limnut in primary_producers.F90 needs max/min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpowley hpowley hpowley left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid options
2 participants
@wathen @hpowley