Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split for flat #55

Merged
merged 5 commits into from
Dec 16, 2024
Merged

refactor: split for flat #55

merged 5 commits into from
Dec 16, 2024

Conversation

barelyhuman
Copy link
Collaborator

!Breaking Change

Previous compat export for both v8 and v9 didn't work as expected in v8 versions post compilation of the library.

Splitting the recommended config into 2 to keep the original v8 compat

Copy link

Size Change: +24 B (+0.56%)

Total Size: 4.3 kB

Filename Size Change
dist/index.js 4.3 kB +24 B (+0.56%)

compressed-size-action

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 100% following, but the change seems reasonable.

@barelyhuman
Copy link
Collaborator Author

not 100% following, but the change seems reasonable.

The plugin: [] and plugin : { valtio: plugin } is the problem.

v9 wants the reference to the plugin definition in the config and v8 would just internally require it and handle it by using the plugin name's

I thought it'd just work but it didn't.

The tests probably will fail, will merge once I'm done fixing them and adding tests for both configs. I don't want to sit and setup eslint configs again and again 😂

@barelyhuman barelyhuman requested a review from dai-shi December 5, 2024 17:12
@barelyhuman
Copy link
Collaborator Author

Kindly review docs as well :)

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
)
}
```
```

### Snapshots mutating is not possible
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add h2 tag? What's the appropriate label?

Suggested change
### Snapshots mutating is not possible
## ...
### Snapshots mutating is not possible

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, why would I add one here? isn't this the part of the why

Validations, Dos and Don'ts , Rules ?

barelyhuman and others added 3 commits December 6, 2024 12:36
@barelyhuman barelyhuman merged commit 1471a10 into main Dec 16, 2024
10 of 11 checks passed
@dai-shi dai-shi deleted the fix/54 branch December 16, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants