-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split for flat #55
Conversation
Size Change: +24 B (+0.56%) Total Size: 4.3 kB
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not 100% following, but the change seems reasonable.
The v9 wants the reference to the plugin definition in the config and v8 would just internally require it and handle it by using the plugin name's I thought it'd just work but it didn't. The tests probably will fail, will merge once I'm done fixing them and adding tests for both configs. I don't want to sit and setup eslint configs again and again 😂 |
Kindly review docs as well :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
) | ||
} | ||
``` | ||
``` | ||
|
||
### Snapshots mutating is not possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add h2 tag? What's the appropriate label?
### Snapshots mutating is not possible | |
## ... | |
### Snapshots mutating is not possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, why would I add one here? isn't this the part of the why
Validations, Dos and Don'ts , Rules ?
Co-authored-by: Daishi Kato <[email protected]>
Co-authored-by: Daishi Kato <[email protected]>
!Breaking Change
Previous compat export for both v8 and v9 didn't work as expected in v8 versions post compilation of the library.
Splitting the recommended config into 2 to keep the original v8 compat