Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update tanstack query integration documentation to the new api #2294

Merged
merged 5 commits into from
Dec 10, 2023
Merged

docs: update tanstack query integration documentation to the new api #2294

merged 5 commits into from
Dec 10, 2023

Conversation

kalijonn
Copy link
Contributor

@kalijonn kalijonn commented Dec 9, 2023

Related Issues or Discussions

Related: jotaijs/jotai-tanstack-query#45

Summary

Check List

  • yarn run prettier for formatting code and docs

Copy link

vercel bot commented Dec 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2023 3:53pm

Copy link

codesandbox-ci bot commented Dec 9, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a3fbe2a:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@kalijonn
Copy link
Contributor Author

kalijonn commented Dec 9, 2023

I'll update csbs after releasing v.0.8.0

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need migration guide to v0.8.0.
Either a section in this doc, or a link to a doc in jotai-tanstack-query repo is fine.

@kalijonn
Copy link
Contributor Author

kalijonn commented Dec 10, 2023

I think we need migration guide to v0.8.0. Either a section in this doc, or a link to a doc in jotai-tanstack-query repo is fine.

I added a migration guide. Can you review the level of detail? Too detailed or not detailed enough?

I also released jotai-tanstack-query v0.8.0 and updated the sandboxes here.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the migration guide is good.

docs/extensions/query.mdx Outdated Show resolved Hide resolved
docs/extensions/query.mdx Outdated Show resolved Hide resolved
kalijonn and others added 2 commits December 10, 2023 21:22
Co-authored-by: Daishi Kato <[email protected]>
Co-authored-by: Daishi Kato <[email protected]>
@dai-shi dai-shi merged commit ad818df into pmndrs:main Dec 10, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants