-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(CONTRIBUTING.md): clarify used scripts #2935
base: main
Are you sure you want to change the base?
docs(CONTRIBUTING.md): clarify used scripts #2935
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
Preview in LiveCodesLatest commit: 1a275f2
See documentations for usage instructions. |
I think we don't need to use |
Thanks for opening up the suggestion. CONTRIBUTING.md isn't well maintained across three repos. So, it's a good chance to overhaul it. Let's have two parts. The first part is common part that is same for all zustand/jotai/valtio. The second part is specific to each lib. What would be your suggestion if you were to write it from scratch? |
The first part sounds good. I think we can combine the best practices of both zustand and jotai. I believe it’s important to keep it concise and clear when writing. |
Yeah, we didn't have one in valtio. |
Yeah, i saw valtio doesn't have it I'll update |
Summary
pnpm run prettier
topnpm run fix:format
pnpm dev
topnpm run dev
for consistency and avoiding aliasCheck List
pnpm run fix:format
for formatting code and docs