docs: fix bunshi example #2937
Merged
docs: fix bunshi example #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Can @loganvolkers review this? |
commit: |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/677NR53MR |
See documentations for usage instructions.
loganvolkers
approved these changes
Jan 15, 2025
@disjukr run fix:format. |
disjukr
force-pushed
the
bunshi-example
branch
from
0c408b2 to
846d342
Compare
Oh, I thought I had run it, but I guess I was mistaken. I ran it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The scope of bunshi is not divided based on the provider in the render tree but rather based on the value of the provider, so using
initialCountas the value of the scope is not appropriate.If multiple providers provide the same
initialCount, they will share the same scope.Therefore, I have modified the example code to wrap the
initialCountonce so that it gets a different reference.Check List
pnpm run fix:formatfor formatting code and docs