Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated jsxBracketSameLine #273

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

bjornstar
Copy link
Member

If you'd like me to back out applying the prettier fixes, I'd be happy to oblige.

@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2021

🦋 Changeset detected

Latest commit: 8f76e42

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/leva/4Ha8TpD8n6BVGPbPsdY8EvXSC63Z
✅ Preview: https://leva-git-fork-bjornstar-jsx-bracket-same-line-is-ac05a3-pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 21, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8f76e42:

Sandbox Source
leva-minimal Configuration
leva-busy Configuration
leva-scroll Configuration
leva-advanced-panels Configuration
leva-ui Configuration
leva-theme Configuration
leva-transient Configuration
leva-plugin-plot Configuration
leva-plugin-bezier Configuration
leva-plugin-spring Configuration
leva-custom-plugin Configuration

@dbismut
Copy link
Collaborator

dbismut commented Nov 21, 2021

Hi, thanks for this! I've just pushed some changes, would you mind rebasing the PR from the latest source on master? I think you might want to revert the prettier on all files and re-run it again once you've pulled the latest code!

@dbismut
Copy link
Collaborator

dbismut commented Nov 21, 2021

Btw, the option has been renamed to bracketSameLine, maybe we should keep it?

@bjornstar
Copy link
Member Author

Btw, the option has been renamed to bracketSameLine, maybe we should keep it?

No problem, I have applied bracketSameLine.

@dbismut dbismut merged commit d4f630b into pmndrs:master Nov 23, 2021
@bjornstar bjornstar deleted the jsx-bracket-same-line-is-deprecated branch November 23, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsxBracketSameLine is deprecated
2 participants