fix: useTransition hook works correctly with a function argument. (#2287) #2289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
#2287.
The useTransition hook doesn't work correctly if we pass a function as an argument.
What
If we pass a function to the hook, a
ref
variable will be created, an instance ofSpringRef
.Then, as stated in the comment, if the
ref
exists, the update is postponed until theref
'sstart
method is called. By calling the ctrlupdate
method, we simply put another item in the queue. Perhaps I didn’t fully understand it, but I didn’t see calling thestart
method on an existingref
that flushes the queue.Calling the
ref
'sstart
method in useIsomorphicLayoutEffect solves the problem.Checklist