Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support removing attributes from animated elements #2293

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LoganDark
Copy link

@LoganDark LoganDark commented Jun 13, 2024

Why

inert does not accept inert='', inert='false', inert='undefined' or etc. The attribute must be entirely removed in order to enable the element again. disabled works the same way.

What

If a value resolves to undefined (not null or false or otherwise) its attribute will now be entirely removed.

Checklist

  • Ready to be merged

Copy link

changeset-bot bot commented Jun 13, 2024

🦋 Changeset detected

Latest commit: 66bf995

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-spring/web Patch
@react-spring/animated Patch
@react-spring/core Patch
@react-spring/parallax Patch
@react-spring/rafz Patch
@react-spring/shared Patch
@react-spring/types Patch
@react-spring/konva Patch
@react-spring/native Patch
@react-spring/three Patch
@react-spring/zdog Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-spring ✅ Ready (Inspect) Visit Preview Jun 13, 2024 2:41pm

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we can evaluate on this being the right thing to do properly, can we add a couple of test cases to animated.test.tsx that shows this working please? :)

@LoganDark
Copy link
Author

LoganDark commented Jun 25, 2024

I suppose right now it's impossible for a spring value to even be null or undefined without an interpolation (at least when using useSpring), because of #2295. I'm off work for the week, so I can look into this more next Monday (especially since writing brand new tests will probably require me to clone/install everything anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants