feat: React 19 support #2349
feat: React 19 support #2349
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
targets/three/src/index.ts
Outdated
| const host = createHost(primitives, { | ||
| // @ts-expect-error r3f related | ||
| applyAnimatedValues: applyProps, | ||
| }) |
There was a problem hiding this comment.
This should probably be a proxy since it is valid to extend the JSX interface beyond what the THREE namespace contains.
This used to be pulled in by R3F, but we vendor it upstream as of late. Even though we intend to later migrate changes, it's best to not depend on transient dependencies.
|
@CodyJasonBennett if you can rebase, i've hopefully fixed the issue with the CI :) |
This comment was marked as resolved.
This comment was marked as resolved.
|
Test runners are supposed to be calling and awaiting I'm not sure how to test React 19 here without rewriting the test suite or its instrumentation. Maybe an e2e test could work? Ideally CI could test a matrix of types and implementation. |
Why
Adds forward support for React 19 and R3F v9.
What
Upstream breaking changes are limited to types, and I opt to remove deprecated patterns where able:
useRef<T>()->useRef<T>(null)JSX->React.JSXMutableRefObject<T>->RefObject<T>useRefandRefObjectare bugged as immutable in 18.3 types)PropsWithRef -> T(omitted; needs indirection for React 18 + 19 support)(R3F)(omitted; this is not backwards compatible to R3F v8.0)JSX.IntrinsicElements->ThreeElementsChecklist