Skip to content

fix: harden XR init against Renderer shim #1846

fix: harden XR init against Renderer shim

fix: harden XR init against Renderer shim #1846

Triggered via pull request July 26, 2023 09:25
Status Success
Total duration 2m 52s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

test.yml

on: pull_request
Build, lint, and test
2m 42s
Build, lint, and test
Fit to window
Zoom out
Zoom in

Annotations

11 warnings
Build, lint, and test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Build, lint, and test: packages/fiber/src/core/index.tsx#L516
React Hook React.useCallback has missing dependencies: 'container', 'events', 'pointer', 'previousRoot', 'raycaster', 'rest', and 'size'. Either include them or remove the dependency array
Build, lint, and test: packages/fiber/src/core/index.tsx#L549
React Hook React.useEffect has missing dependencies: 'inject', 'previousRoot', and 'usePortalStore'. Either include them or remove the dependency array
Build, lint, and test: packages/fiber/src/core/index.tsx#L553
React Hook React.useEffect has missing dependencies: 'previousRoot' and 'usePortalStore'. Either include them or remove the dependency array
Build, lint, and test: packages/test-renderer/src/__tests__/RTTR.core.test.tsx#L20
Caution: `ReactThreeTestRenderer` also has a named export `create`. Check if you meant to write `import {create} from '../index'` instead
Build, lint, and test: packages/test-renderer/src/__tests__/RTTR.core.test.tsx#L38
Caution: `ReactThreeTestRenderer` also has a named export `create`. Check if you meant to write `import {create} from '../index'` instead
Build, lint, and test: packages/test-renderer/src/__tests__/RTTR.core.test.tsx#L59
Caution: `ReactThreeTestRenderer` also has a named export `create`. Check if you meant to write `import {create} from '../index'` instead
Build, lint, and test: packages/test-renderer/src/__tests__/RTTR.core.test.tsx#L72
Caution: `ReactThreeTestRenderer` also has a named export `create`. Check if you meant to write `import {create} from '../index'` instead
Build, lint, and test: packages/test-renderer/src/__tests__/RTTR.core.test.tsx#L100
Caution: `ReactThreeTestRenderer` also has a named export `create`. Check if you meant to write `import {create} from '../index'` instead
Build, lint, and test: packages/test-renderer/src/__tests__/RTTR.core.test.tsx#L152
Caution: `ReactThreeTestRenderer` also has a named export `create`. Check if you meant to write `import {create} from '../index'` instead
Build, lint, and test: packages/test-renderer/src/__tests__/RTTR.core.test.tsx#L159
Caution: `ReactThreeTestRenderer` also has a named export `create`. Check if you meant to write `import {create} from '../index'` instead