Merge pull request #2871 from Nicetouchco/fix/dispose

[v9] fix: dispose properly binds its object
pmndrs · Jun 10, 2023 · cab6d59 · cab6d59
2 parents 35333c9 + 9e0b2d1
commit cab6d59
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/fiber/src/core/reconciler.ts b/packages/fiber/src/core/reconciler.ts
@@ -215,8 +215,8 @@ function removeChild(
   //   - cannot be a <primitive object={...} />
   //   - cannot be a THREE.Scene, because three has broken its own API
   if (shouldDispose && child.type !== 'primitive' && child.object.type !== 'Scene') {
-    const dispose = child.object.dispose
-    if (typeof dispose === 'function') {
+    if (typeof child.object.dispose === 'function') {
+      const dispose = child.object.dispose.bind(child.object)
       scheduleCallback(idlePriority, () => {
         try {
           dispose()