-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v9] experiment: rework reconciler architecture, create objects on commit #2378
Closed
Closed
Changes from 30 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
e7a1025
experiment: separate instance & object, create objects on commit
CodyJasonBennett 7eccdc0
fix(detach): overwrite target
CodyJasonBennett 30b3227
fix(renderer): add back removerecursive
CodyJasonBennett ee03b1d
fix(renderer): safely check objects when hiding/suspense
CodyJasonBennett 5e97a14
fix(applyProps): use target args on HMR copy
CodyJasonBennett ebced55
fix(diffProps): filter reserved keys
CodyJasonBennett 8334dad
refactor: cleanup prop diffing
CodyJasonBennett 4f3da21
refactor(RTTR): use new instance structure, cleanup internal types
CodyJasonBennett 3aea5b2
fix: safely add object3ds on commit
CodyJasonBennett ae3c219
fix(renderer): update instance on commitupdate, cleanup prop filter
CodyJasonBennett 67ecde9
fix: safely check container parents, de-dup interaction on commit
CodyJasonBennett 7dec566
fix(RTTR): correctly traverse root react element
CodyJasonBennett 58d656f
chore(tests): update instance snapshot
CodyJasonBennett 9ab0eb7
chore(RTTR): make sure fireEvent warns on invalid prop
CodyJasonBennett 0720009
fix(renderer): safely append to container
CodyJasonBennett c112c8d
fix(renderer): loosen commit append to parents
CodyJasonBennett f43e768
fix(renderer): de-ref oldinstance after swap
CodyJasonBennett 656d11b
fix(RTTR): don't use internal container methods
CodyJasonBennett f2db2f9
refactor(RTTR): cleanup fiber traversal
CodyJasonBennett d5fb4a7
chore(types): don't export internal props
CodyJasonBennett 975a2ba
fix: hide non-renderable objects on suspend
CodyJasonBennett c5f1793
Merge branch 'master' into experiment/commit-architecture
CodyJasonBennett 775e485
Merge branch 'v9' into experiment/commit-architecture
CodyJasonBennett 191a4fc
fix(renderer): always attach instance localstate
CodyJasonBennett 08ac484
Merge branch 'v9' into experiment/commit-architecture
CodyJasonBennett 35056e8
fix: handle text cases, add coverage
CodyJasonBennett ef8c6a2
Merge branch 'v9' into experiment/commit-architecture
CodyJasonBennett d5402e0
chore: fix conflicts
CodyJasonBennett 59a3aef
chore: lint
CodyJasonBennett 50a1fad
experiment: add suspense boundaries to portals example
CodyJasonBennett 31927b6
Merge branch 'v9' into experiment/commit-architecture
CodyJasonBennett ac63742
experiment: commit on finalizeInitialChildren
CodyJasonBennett eabc13b
fix: revert commit on finalizeInitialChildren
CodyJasonBennett 0614a16
Merge branch 'v9' into experiment/commit-architecture
CodyJasonBennett 5b3a237
Merge branch 'v9' into experiment/commit-architecture
CodyJasonBennett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR causes ULE in
Portal
to fire without a ref attached outside ofcreatePortal
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like reconciler hook timings are really off for elements coming off of suspend as well.