Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Prettier CI/CD, remove deprecated options #3260

Merged
merged 6 commits into from
Aug 10, 2024

Conversation

satelllte
Copy link
Contributor

What's changed

Copy link

codesandbox-ci bot commented May 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3380381:

Sandbox Source
example Configuration

Comment on lines +44 to +45
- name: Check formatting
run: yarn run format
Copy link
Contributor Author

@satelllte satelllte May 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionally, this can be moved earlier: before or after "Check lint" step

node_modules/
.yarn/
*.gltf
*.mdx
Copy link
Contributor Author

@satelllte satelllte May 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignored MDX files, because semi rule set to false and it adds semicolons at the beginning of root-level JSX code.

For example, this:

import { PerspectiveCamera } from '@react-three/drei'
<Canvas>
  <PerspectiveCamera makeDefault manual />
</Canvas>

gets replaced by this:

import { PerspectiveCamera } from '@react-three/drei'
;<Canvas>
  <PerspectiveCamera makeDefault manual />
</Canvas>

@satelllte satelllte marked this pull request as ready for review May 9, 2024 18:48
@CodyJasonBennett CodyJasonBennett changed the title Prettier: CI/CD, Remove deprecated options chore: Prettier CI/CD, remove deprecated options Aug 10, 2024
@CodyJasonBennett CodyJasonBennett merged commit 642dcec into pmndrs:master Aug 10, 2024
2 checks passed
@satelllte satelllte deleted the prettier branch August 10, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants