Skip to content

Commit

Permalink
ch4/posix: making topology aware SHM default to enabled
Browse files Browse the repository at this point in the history
Fix the performance degradation on Intel Sapphire Rapids after
introducing topo-aware SHM. This problem only happens when building
with Intel compiler. The problem was topo-aware default
to disabled. It uses regular memcpy for inter-NUMA message which
is different from v4.2.2 (uses non-temporal copy).

The reason this is disabled by default was due to using non-temporal
copy results in higher latency in small message. After more testing
with different CPUs (broadwell, skylake, cascade, icelake, milan),
It seems only skylake, cascade and icelake has this issue on small
message. It is probably OK to make topo-aware SHM default to enabled.
  • Loading branch information
yfguo committed Sep 27, 2024
1 parent 7a91c22 commit 2425896
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/mpid/ch4/shm/posix/posix_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
- name : MPIR_CVAR_CH4_SHM_POSIX_TOPO_ENABLE
category : CH4
type : boolean
default : false
default : true
class : none
verbosity : MPI_T_VERBOSITY_USER_BASIC
scope : MPI_T_SCOPE_ALL_EQ
Expand Down

0 comments on commit 2425896

Please sign in to comment.