ch4: assert group before communicator commit

Add assertions to make sure the local_group and remote_group (for inter communicators) are always set before MPID_Comm_commit_pre_hook.
pmodels · Dec 12, 2024 · acda531 · acda531
1 parent 13e16a5
commit acda531
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/mpid/ch4/src/ch4_comm.c b/src/mpid/ch4/src/ch4_comm.c
@@ -140,6 +140,9 @@ int MPID_Comm_commit_pre_hook(MPIR_Comm * comm)
     int mpi_errno;
     MPIR_FUNC_ENTER;
 
+    MPIR_Assert(comm->local_group);
+    MPIR_Assert(comm->comm_kind == MPIR_COMM_KIND__INTRACOMM || comm->remote_group);
+
     if (comm == MPIR_Process.comm_world) {
         MPIDI_COMM(comm, map).mode = MPIDI_RANK_MAP_DIRECT_INTRA;
         MPIDI_COMM(comm, map).avtid = 0;