Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct pmix.h when configuring with external PMIx lib #7243

Open
sonjahapp opened this issue Dec 19, 2024 · 1 comment · May be fixed by #7246
Open

Use correct pmix.h when configuring with external PMIx lib #7243

sonjahapp opened this issue Dec 19, 2024 · 1 comment · May be fixed by #7246

Comments

@sonjahapp
Copy link
Contributor

If MPICH is configured with an external PMIx library using

  • --with-pmix=<path to pmix lib>
  • and in addition MPICHs built-in PMI1/2 support is enabled via --with-pmilib=mpich

the wrong PMIx header file is used at compile time. It uses src/pmi/include/pmix.h instead of the header provided in <path to pmix lib>.

Is there a combination of MPICH configure options that can prevent this?

Could this be fixed by, for example, changing src/pmi/Makefile.am to exclude all the pmix* files in src/pmi/ from compilation when an external PMIx lib is configured? Or do the pmix* files (at least the headers) have to get their own subdirectory to avoid naming clashes for pmix.h?

Thank you! :)
@hzhou
Copy link
Contributor

hzhou commented Dec 19, 2024

Ahh, the issue is we have pmix.h in the same path as pmi.h and pmi2.h, so the include path src/pmi/include clobbered the <path to pmix lib>. May be we can move our internal pmix.h to a subfolder.

@sonjahapp sonjahapp linked a pull request Dec 20, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pmi: avoid name clash of pmix.h with external pmix lib sonjahapp/mpich
2 participants
@hzhou @sonjahapp