pmi: avoid name clash of pmix.h with external pmix lib #7246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonjahapp
force-pushed
the
pr-issue-7243-pmix-header
branch
from
183d6f4 to
3df3246
Compare
hzhou
approved these changes
Dec 20, 2024
|
test:mpich/pmi There issues running pmix with hydra. I'll look into it later. |
hzhou
force-pushed
the
pr-issue-7243-pmix-header
branch
from
2440616 to
8be30aa
Compare
|
test:mpich/pmi ✔️ |
|
@sonjahapp I added two commits. One fixing the testing harness. And the other slightly alters the way to include pmix/pmix.h. Let me know if you are okay with it. |
raffenet
approved these changes
Jan 3, 2025
This prevents a name clash between MPICH's pmix.h and the header of an external PMIx library.
When running hydra using pmix, somehow we changed the default stdout flush mode and it is not flushing after the newline. This causes the multi-tests mode hang. Adding explicit flushing fixes it.
We put embedded pmix.h to the pmix subdir to avoid clashing with system pmix.h. Adding it to CPPFLAGS makes it depending on the rather obscure inclusion order. Rather, include pmix/pmix.h explicitly in the code when we know we are building embedded pmix. This is consistent with how we do it in src/pmi/src/pmix.c.
hzhou
force-pushed
the
pr-issue-7243-pmix-header
branch
from
8be30aa to
612cebb
Compare
Happy new year and thanks for merging! I had to cherry-pick this change to make the include solution for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #7243
This is the solution that we use for ParaStation MPI to circumvent the problem for now.
Better ideas are welcome. :)
Happy holidays!
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.