-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
romio: redefine MPI_DISPLACEMENT_CURRENT #7247
Conversation
1cb7c44
to
7cefb98
Compare
test:mpich/ch3/tcp test:mpich/custom Somehow cvars such as |
7cefb98
to
05c3ec9
Compare
test:mpich/custom |
@@ -425,7 +425,7 @@ enum { | |||
}; | |||
|
|||
/* File Operation Constants */ | |||
#define MPI_DISPLACEMENT_CURRENT ((MPI_Offset)-54278278) | |||
#define MPI_DISPLACEMENT_CURRENT ((MPI_Offset)-1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look OK with this value. Should be propose a change to https://github.com/mpi-forum/mpi-standard/pull/977 for next week's second vote?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me drop the last commit (05c3ec9) and test. If test pass, it means we can maintain both MPICH ABI and whatever negative value MPI ABI will use.
05c3ec9
to
488b8f8
Compare
test:mpich/custom |
test:mpich/ch3/tcp ✔️ |
@raffenet @hzhou Could you please bump priority to the review & merge of this PR? mpi4py's MPI ABI testing requires the MPI ABI stubs header and MPICH's MPI ABI implementation in sync. |
488b8f8
to
fd918a7
Compare
Otherwise, the MPI_T functions may not able to convert builtin datatypes.
fd918a7
to
da3a9b1
Compare
Pull Request Description
It is quite odd to have
-54278278
forMPI_DISPLACEMENT_CURRENT
let users and developers wonder its reasons. In fact, I believe this is used as a sentinel dummy argument and an arbitary value should work.The value
-1
is as arbitrary as-54278278
and people won't wonder.Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short description
Commit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.