binding/io: misc issues related to io binding generation #7276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzhou
force-pushed
the
2501_fortran_io
branch
2 times, most recently
from
316d1e7 to
fd39c3f
Compare
|
test:mpich/ch3/tcp ✔️ test:mpich/custom --disable-romio |
hzhou
changed the title
hzhou
force-pushed
the
2501_fortran_io
branch
from
279d3e4 to
b99a70f
Compare
|
test:mpich/custom --disable-romio |
|
test:mpich/ch4/most |
raffenet
approved these changes
Feb 3, 2025
Now all f2c/c2f functions are actual C functions (rather than macros), the f08 binding can directly call those functions. This is one step toward MPI ABI since it no longer assume handles are integers. The next step is to adjust handle sizes (e.g. c_Comm) based on whether mpi ABI is enabled. What about PMPI f2c interfaces such as PMPI_File_f2c? I am punting it until someone asks for it.
Now MPI-IO functions are always available -- dummy functions if ROMIO is disabled -- the fortran bindings no longer need the "-no-mpiio" option.
The autoconf macro HAVE_CXX_IO is used in mpicxx.h to exclude MPI IO interfaces if ROMIO is disabled. Similarly, the macro HAVE_ROMIO is used in initcxx.cxx to exclude IO when ROMIO is disabled. Now our binding layer will generate dummy MPI IO routines when ROMIO is disabled, we no longer need the exclusions in the CXX binding.
Downstream applications such as mpi4py need a way to check whether ROMIO is enabled and relies on the ROMIO_VERSION macro. It is used to be defined in `mpio.h`. Now we no longer use mpio.h, it needs to be in mpi.h.
Now mpich will generate io function prototypes and mpio.h is no longer needed.
Unlike the begin routines (e.g. MPI_File_write_all_begin), the end routines (e.g. MPI_File_write_all_end) doesn't provide count or datatype, so we have no way of knowing whether the `buf` parameter is may be NULL or not. Thus, skip the NULL pointer check.
* Remove leftover `check_PYTHON` call. The PYTHON is already checked with check_python3() earlier. * In checking existence of mydef_boot, check its bin folder. The module path (modules/mydef_boot) may exist even without submodule checkout. * Add cast to suppress the "%lld" printf when the actual type may be "long" instead of "long long". * Add -w in Makefile_f77.mtest to suppress all warnings since gfortran always gives warnings despite -fallow-argument-mismatch.
@FORTRAN_MPI_OFFSET@ is used in mpif.h.in to define MPI_DISPLACEMENT_CURRENT. Set it in MPICH configure rather than get it from ROMIO configure.
Now that MPI-IO is always available in the interface, we need check mpichversion to see whether romio is disabled during build. Only define HAVE_MPI_IO if romio is not disabled.
hzhou
force-pushed
the
2501_fortran_io
branch
from
a0dd7ad to
3f32763
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Now all f2c/c2f functions are actual C functions (rather than macros), the f08 binding can directly call those functions.
This is one step toward MPI ABI since it no longer assume handles are
integers. The next step is to adjust handle sizes (e.g. c_Comm) based on
whether mpi ABI is enabled.
Now MPI-IO functions are always available -- dummy functions if ROMIO is
disabled -- the fortran bindings no longer need the "-no-mpiio" option.
Remove
HAVE_CXX_IOandHAVE_ROMIOcheck in the CXX binding.Add back the
ROMIO_VERSIONmacro inmpi.h(since some downstream relies on it)Skip installing
mpio.hif buildsFROM_MPICHFixes #7278
Fixes #7277
[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.